[noise] [Noise] Go implementation
Jonathan Rudenberg
jonathan at titanous.com
Sun Jul 6 14:43:49 PDT 2014
On Jul 6, 2014, at 2:36 PM, Trevor Perrin <trevp at trevp.net> wrote:
> On Sun, Jul 6, 2014 at 1:12 PM, Jonathan Rudenberg
> <jonathan at titanous.com> wrote:
>> On Jul 6, 2014, at 12:45 PM, Trevor Perrin <trevp at trevp.net> wrote:
>>
>>> The KDF logic in your deriveKey() could be clearer.
>>
>> I refactored it a bit last night:
>>
>> https://github.com/titanous/noise/blob/84c8891ca786088286cf2461d4237a0de5da2b9e/box/box.go#L172-L175
>>
>> Is there anything specific that you think would make it clearer?
>
> Looks better, but I think the extra and info are reversed.
Thanks, fixed.
> kdf_num is not actually state or a counter, it's just so every
> different use of the KDF gives completely different results, even if
> passed the same input. Which helps the security analysis. I added
> more comments last night, see if that helps explain, or if there's
> something else we can do to clarify.
Okay, that makes sense. I will refactor how it is handled.
Jonathan
More information about the Noise
mailing list